You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No support for push0, causing the wastage of several gas.
This updates to solc 0.8.22. I think it reduces gas for all simple tests, but unfortunately increases gas usage for the uniswap createPair test. I plan to look into that case and see what's up.
How was it fixed?
solc 0.8.20 0.8.22
evm crate had to be upgraded for tests; to keep the tests working I had to hack around a bunch of changes.
solc fails to generate json for the "irAst" output in cases with a lot of nesting in our generated Yul code, which happens for tests with a lot of asserts (binary_ops.fe and comp_ops.fe, in particular). I had to disable this output. (I'll create an issue for our perhaps less-than-ideal codegen)
If it turns out that this will change the runtime code of the recently deployed contracts, then I will cut two releases just to make sure people have a way to verify the already deployed contracts.
Ok, I verified that this does indeed result in different bytecode. I'm going to cut a release now without this PR and merge it after that. We can then cut another release shortly before devconnect that includes this and potentially other stuff.
Ok, I verified that this does indeed result in different bytecode. I'm going to cut a release now without this PR and merge it after that. We can then cut another release shortly before devconnect that includes this and potentially other stuff.
This doesn't have to be merged or released before devconnect; it can wait for some future release. I'm just trying to tie up some loose ends.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sbillig
force-pushed
the
solc-0820
branch
3 times, most recently
from
What was wrong?
No support for push0, causing the wastage of several gas.
This updates to solc 0.8.22. I think it reduces gas for all simple tests, but unfortunately increases gas usage for the uniswap createPair test. I plan to look into that case and see what's up.
How was it fixed?
solc
0.8.200.8.22evm crate had to be upgraded for tests; to keep the tests working I had to hack around a bunch of changes.
solc fails to generate json for the "irAst" output in cases with a lot of nesting in our generated Yul code, which happens for tests with a lot of
asserts (binary_ops.fe and comp_ops.fe, in particular). I had to disable this output. (I'll create an issue for our perhaps less-than-ideal codegen)