Self-review errors.As pointer usage

ethereum · Jan 20, 2025 · 4209f1c · 4209f1c
1 parent d46e1b0
commit 4209f1c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/p2p/dnsdisc/error.go b/p2p/dnsdisc/error.go
@@ -47,7 +47,7 @@ type nameError struct {
 }
 
 func (err nameError) Error() string {
-	ee := new(entryError)
+	var ee entryError
 	if errors.As(err.err, &ee) {
 		return fmt.Sprintf("invalid %s entry at %s: %v", ee.typ, err.name, ee.err)
 	}

diff --git a/rlp/typecache.go b/rlp/typecache.go
@@ -141,7 +141,7 @@ func structFields(typ reflect.Type) (fields []field, err error) {
 	// Filter/validate fields.
 	structFields, structTags, err := rlpstruct.ProcessFields(allStructFields)
 	if err != nil {
-		tagErr := new(rlpstruct.TagError)
+		var tagErr rlpstruct.TagError
 		if errors.As(err, &tagErr) {
 			tagErr.StructType = typ.String()
 			return nil, tagErr