cmd/evm: restore --bench flag to evm statetest #31055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore the --bench flag to `evm statetest`, as well as testing for its function in `evm run` and `evmstatetest`
shemnon
requested review from
holiman,
MariusVanDerWijden and
lightclient
as code owners
jwasinger
previously approved these changes
Jan 21, 2025
fjl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the
evmcommand moved where some commands were valid. One command,--bench, used to work inevm statetest. The pluming is still in place. This PR puts the--benchflag in the place the trace flags were moved, and adds tests to validate the bench flag operates inrunandstatetest