Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing out-of-heap error due to large memory copy #445

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Conversation

msooseth
Copy link
Collaborator

@msooseth msooseth commented Jan 23, 2024

Description

This issue is related to #444. I am fixing it by returning IllegalOverflow, which is what we already do, although we only check $2^{64}$, not 2^{28}$. However, it's mostly the same thing -- way too large of a number.

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

Copy link
Collaborator

@arcz arcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) this error is annoying

@msooseth msooseth merged commit 63f32d0 into main Feb 5, 2024
7 checks passed
@msooseth
Copy link
Collaborator Author

msooseth commented Feb 5, 2024

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants