Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using with-utf8 so we don't encounter weird locale issues anymore #452

Merged
merged 1 commit into from
Mar 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Using with-utf8 so we don't encounter weird utf8 issues anymore
  • Loading branch information
msooseth committed Mar 4, 2024
commit 1c9ec417b8a124ebbd3f635588c919f9ec3b827b
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## Added

## Fixed
-- `concat` is a 2-ary, not an n-ary function in SMT2LIB, declare-const does not exist in QF_AUFBV, replacing
- `concat` is a 2-ary, not an n-ary function in SMT2LIB, declare-const does not exist in QF_AUFBV, replacing
with declare-fun
- CVC5 needs `--incremental` flag to work properly in abstraction-refinement mode
- cli.hs now uses with-utf8 so no release binary will have locale issues anymore

## [0.53.0] - 2024-02-23


## Changed

- Minimum distance requirements are now asserted for Keccak function calls. They assert that it's hard to generate two Keccak's that are less than 256 afar.
Expand Down Expand Up @@ -47,7 +48,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Traces now correctly perform source mapping to display contract details
- Event traces now correctly display indexed arguments and argument names
- JSON reading of foundry JSONs was dependent on locale and did not work with many locales.
- CVC5 needs `--incremental` flag to work properly in abstraction-refinement mode

## [0.52.0] - 2023-10-26

Expand Down
3 changes: 2 additions & 1 deletion cli/cli.hs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import Paths_hevm qualified as Paths
import System.Directory (withCurrentDirectory, getCurrentDirectory, doesDirectoryExist, makeAbsolute)
import System.FilePath ((</>))
import System.Exit (exitFailure, exitWith, ExitCode(..))
import Main.Utf8 (withUtf8)

import EVM (initialContract, abstractContract, makeVm)
import EVM.ABI (Sig(..))
Expand Down Expand Up @@ -197,7 +198,7 @@ getFullVersion = showVersion Paths.version <> " [" <> gitVersion <> "]"
Left _ -> "no git revision present"

main :: IO ()
main = do
main = withUtf8 $ do
cmd <- Options.unwrapRecord "hevm -- Ethereum evaluator"
let env = Env { config = defaultConfig
{ dumpQueries = cmd.smtdebug
Expand Down
3 changes: 2 additions & 1 deletion hevm.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,8 @@ executable hevm
optics-core,
githash >= 0.1.6 && < 0.2,
witch,
unliftio-core
unliftio-core,
with-utf8 >= 1.0.0.0
if os(windows)
buildable: False

Expand Down
Loading