Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing partial warning for missing cheatcode #640

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fixing partial warning for missing cheatcode #640

merged 1 commit into from
Jan 29, 2025

Conversation

msooseth
Copy link
Collaborator

@msooseth msooseth commented Jan 27, 2025

Description

We actually didn't produce a partial execution trace when a cheatcode was not found. I now added a test that would have failed before.

It now says:

ghci> :main -p "cheatcode-nonexistent"
hevm
  Panic code tests via symbolic execution
    cheatcode-nonexistent:    WARNING: hevm was only able to partially explore the call prefix 0x7a9839c2 due to the following issue(s):
     - Cheat code not recognized
     program counter: 181
     selector: 0xcd09029c
OK (0.02s)

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@msooseth msooseth changed the title Fixing "partial" END for missing cheatcode Fixing partial warning for missing cheatcode Jan 27, 2025
@msooseth msooseth marked this pull request as ready for review January 27, 2025 15:19
@msooseth msooseth requested a review from blishko January 27, 2025 15:20
Copy link
Collaborator

@blishko blishko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msooseth msooseth merged commit a373de3 into main Jan 29, 2025
9 checks passed
@msooseth msooseth deleted the fix-partial branch January 29, 2025 09:35
@msooseth
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants