Update more precise smt address encoding PR #641
+76
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds constraints that ensure that symbolic addresses that are used to key the contracts mapping cannot alias any other keys.
4 tasks
msooseth
changed the title
msooseth
force-pushed
the
upd-more-precise-smt-address-encoding
branch
from
29d9599 to
69b702b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an update to #376 that makes it work for the test cases added to that PR. As per @d-xo 's description:
This adds some more assertions during encoding around the values of symbolic addresses. Still needed is a pass that asserts that all symbolic addresses are pairwise distinct with all known concrete addresses.I have added the part that they are pairwise distinct. It is also working now because it checks the addresses before they get erased through the revert that
VMFailuredoes. So the generation of the constraints is done before theVMFailure's revert. This fixes the underlying issue that I think may have been created since that PR.Checklist