Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Regex on Line 127 in _solidity.py #873

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Arbitrage0
Copy link

@Arbitrage0 Arbitrage0 commented May 4, 2018

Hi, I had a feeling that the added '/' in the regex was messing up with returning the solidity compiler version, because for me it kept returning None, however removing that made it better. I'm presuming that by adding the '/' it searches the base text for a literal match of the '/', and can't tell what other function it performs. Please do check.

Hi, I had a feeling that the added '/' in the regex was messing up with returning the solidity version, because for me it kept returning "None", however removing that made it better. Please do check.
@joeykrug
Copy link
Contributor

joeykrug commented May 5, 2018

Ah yes I noticed this before too, didn’t catch the regex as the cause tho. Thanks!

@Arbitrage0
Copy link
Author

Arbitrage0 commented May 5, 2018

To be honest, it could also be that the case that subprocess.check_output() is a bit buggy too, since it would return the output immediately but wouldn't save it as a string. That was my problem initially as well, which is also one of the possible reasons why the compiler_version() method returns None. Made a change to that as well, do check.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants