Merge pull request #7496 from ethereum/arraysOfRecursiveStructs

Fix internal compiler error for arrays of recursive structs.

Changelog.md

@@ -16,6 +16,7 @@ Bugfixes:
  * Code Generator: Fix internal error when popping a dynamic storage array of mappings.
  * Name Resolver: Fix wrong source location when warning on shadowed aliases in import declarations.
  * Scanner: Fix multi-line natspec comment parsing with triple slashes when file is encoded with CRLF instead of LF.
+ * Type System: Fix arrays of recursive structs.
  * Yul Optimizer: Fix reordering bug in connection with shifted one and mul/div-instructions in for loop conditions.
 
 

libsolidity/ast/Types.cpp

@@ -2050,6 +2050,8 @@ unsigned StructType::calldataOffsetOfMember(std::string const& _member) const
 
 bool StructType::isDynamicallyEncoded() const
 {
+	if (recursive())
+		return true;
 	solAssert(interfaceType(false).get(), "");
 	for (auto t: memoryMemberTypes())
 	{

test/libsolidity/semanticTests/structs/array_of_recursive_struct.sol

@@ -0,0 +1,12 @@
+contract Test {
+    struct RecursiveStruct {
+        RecursiveStruct[] vals;
+    }
+
+    function func() public pure {
+        RecursiveStruct[1] memory val = [ RecursiveStruct(new RecursiveStruct[](42)) ];
+        assert(val[0].vals.length == 42);
+    }
+}
+// -----
+// func() ->

test/libsolidity/syntaxTests/structs/recursion/static_array_of_recursive_structs.sol

@@ -0,0 +1,10 @@
+contract Test {
+    struct RecursiveStruct {
+        RecursiveStruct[] vals;
+    }
+
+    function func() private pure {
+        RecursiveStruct[1] memory val;
+        val;
+    }
+}