Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common: Re-add Deep Copy for Params #3572

Closed
holgerd77 opened this issue Aug 9, 2024 · 0 comments · Fixed by #3613
Closed

Common: Re-add Deep Copy for Params #3572

holgerd77 opened this issue Aug 9, 2024 · 0 comments · Fixed by #3613

Comments

@holgerd77
Copy link
Member

Just quickly dropping here so that it does not get forgotten, we need to re-add deep copy of the params in Common here #3545 (comment) and somewhere Jochem mentioned in one of these PRs (guess for the copy()-type method).

Otherwise this will have side effects in some cases.

(e.g. Common initialized with some param set, changing a param from the original param set for whatever reasons will change the param in Common if we do not deep-copy).

(might do this myself, just not in "dev mode" right now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant