You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just quickly dropping here so that it does not get forgotten, we need to re-add deep copy of the params in Common here #3545 (comment) and somewhere Jochem mentioned in one of these PRs (guess for the copy()-type method).
Otherwise this will have side effects in some cases.
(e.g. Common initialized with some param set, changing a param from the original param set for whatever reasons will change the param in Common if we do not deep-copy).
(might do this myself, just not in "dev mode" right now)
The text was updated successfully, but these errors were encountered:
Just quickly dropping here so that it does not get forgotten, we need to re-add deep copy of the params in Common here #3545 (comment) and somewhere Jochem mentioned in one of these PRs (guess for the copy()-type method).
Otherwise this will have side effects in some cases.
(e.g. Common initialized with some param set, changing a param from the original param set for whatever reasons will change the param in Common if we do not deep-copy).
(might do this myself, just not in "dev mode" right now)
The text was updated successfully, but these errors were encountered: