Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: Deep-Copy Fix #3613

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Common: Deep-Copy Fix #3613

merged 6 commits into from
Aug 26, 2024

Conversation

holgerd77
Copy link
Member

Replaces #3608

@holgerd77 holgerd77 mentioned this pull request Aug 26, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.75%. Comparing base (4470cc3) to head (338922e).
Report is 19 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block ?
client ?
evm 64.78% <ø> (?)
statemanager 66.17% <ø> (?)
trie 51.98% <ø> (?)
tx ?
util 70.20% <ø> (?)
vm 59.17% <ø> (?)
wallet ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member Author

(can confirm that #3593 is not fixed by this, so this is unrelated)

@scorbajio scorbajio linked an issue Aug 26, 2024 that may be closed by this pull request
Common: Re-add Deep Copy for Params #3572
Closed
scorbajio
scorbajio approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@scorbajio scorbajio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scorbajio scorbajio merged commit c64f948 into master Aug 26, 2024
38 checks passed
@scorbajio scorbajio deleted the common-deep-copy-fix-new branch August 26, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scorbajio scorbajio scorbajio approved these changes

Assignees
No one assigned
Labels
package: common PR state: needs review type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Common: Re-add Deep Copy for Params
2 participants
@holgerd77 @scorbajio