-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement t8ntool to use for execution-spec-tests / VM Block Builder Adjustments #3603
Conversation
evm: fix extcodehash/extcodesize for delegated accounts
1dc0b31
to
7dc01c6
Compare
fi | ||
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) | ||
export NODE_OPTIONS="--max-old-space-size=4096" | ||
tsx "$SCRIPT_DIR/launchT8N.ts" "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tsx "$SCRIPT_DIR/launchT8N.ts" "$@" | |
npx tsx "$SCRIPT_DIR/launchT8N.ts" "$@" |
This way it will run even if I only have tsx
installed locally within ethjs and not globally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Was able to get the fill process to run.
Thanks a lot all, this was a huge process, but super happy to get this merged now 😄 Together with ethereum/execution-spec-tests#752 we are now ready "out-of-the-box" to fill tests 😄 🚀 |
🎉🎉🎉 |
Hi @holgerd77, the slow stuff of t8n has not much to do with using MCL. It is simply the load time of all our libraries. It is done each time t8n is called, which can be done multiple times per test (in fact, for each block t8n is called). I have on the agenda a separate PR to open up a server daemon which will then remove this "cold load" time and instead "hot load" the VM. This will drastically speed up the runtime of this tool (for multiple tests). You could think of this when running the Blockchain tests, except now you dont run it with the default settings but instead you run Note that for BLS tests MCL is indeed somewhat faster (we have seen in the Blockchain tests a decrease from ~7 seconds to something like ~6 seconds). However that is for all tests, this ~1 second change is already what would be saved if we would "hot load" the libraries. I plan to add this server daemon asap! |
Ah ok, makes a lot of sense, thanks for the insight! 🤯 Also thanks for planning ahead on this already! 🙏 |
Resolves #3602
This PR implements T8NTool, used for
execution-spec-tests
to fill (and in the future: write) tests. To see how it works, check the t8ntool readme invm/test/t8n/README.md
.