Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common deep copy refactor #3608

Closed
wants to merge 8 commits into from
Closed

Common deep copy refactor #3608

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e1654c0
Add test for deep copy
scorbajio Aug 20, 2024
19203eb
Move over to deep copying common parameters
scorbajio Aug 20, 2024
6a1ad54
Update tests
scorbajio Aug 21, 2024
e9f05e9
Update copy function and parameter copy throughout common class
scorbajio Aug 21, 2024
1108ee3
Remove unused class field
scorbajio Aug 21, 2024
012217b
Merge branch 'master' into common-deep-copy-refactor
scorbajio Aug 21, 2024
8470236
switch param updates to use `updateParams`
acolytec3 Aug 22, 2024
4010916
set hardfork to match old common
acolytec3 Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/common/src/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,8 +841,13 @@ export class Common {
* Returns a deep copy of this {@link Common} instance.
*/
copy(): Common {
const copy = Object.assign(Object.create(Object.getPrototypeOf(this)), this)
copy.events = new EventEmitter()
const copy = new Common({
chain: { ...this._chainParams },
eips: [...this._eips],
customCrypto: this.customCrypto,
})
copy.updateParams(this._params)
copy.setHardfork(this.hardfork())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code has never been touched by any refactor, I am really not seeing why we should change this now.

Also, side note, the spread operator ... has issues with nested copying, see e.g. this example:

grafik

That's why spread is generally not so suitable.

Also to note: side adding setHardfork() can have massive side effects here, I remember similar experiments in the past.

return copy
}
}
Loading