Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM: exit early on non-existing system contracts #3614

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Conversation

jochem-brouwer
Copy link
Member

T8NTool / test fix: we touch system accounts and leave them empty once generating tests (even if those do not exist): this PR exits early and does not write non-existing (as opposed to - SIGH empty accounts) to the trie

@jochem-brouwer
Copy link
Member Author

Not ready, creates weird results using t8n. Will mark ready for review once ready

@jochem-brouwer
Copy link
Member Author

PR is done, this:

  1. Exits early if there is no code deposited in the system contract (so this is not 0xffff..fffe, but rather the system contract, usually an account starting with a lot of zeros)
  2. The system address is restored to the original state of the system address after the system call. (EVM bumps nonce, this should be rolled back)
  3. Note before, we threw if code does not exist at the system contract. However, there are t8ntool tests (Prague tests) which expects the pre-state to be non-filled with system contracts, and therefore the output should also not contain those (we could however not run these blocks, since these threw).

@jochem-brouwer jochem-brouwer marked this pull request as ready for review September 2, 2024 15:21
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit db0e8b2 into master Sep 2, 2024
38 checks passed
@acolytec3 acolytec3 deleted the early-fail-system branch September 2, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants