verkle: extract static constructor #3616
Conversation
ScottyPoi
added
PR state: needs review
type: refactor
breaking
target: master
ScottyPoi
force-pushed
the
verkle-constructor
branch
from
e48336c
to
1191c66
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -24,6 +21,8 @@ import { | |||
| type VerkleTreeOptsWithDefaults, | |||
| } from './types.js' | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
| import type { createVerkleTree } from './constructors.js' // Imported so intellisense can display docs | |||
There was a problem hiding this comment.
Ah, yeah, I stumbled over this as well at some point. It would really be good if this can be solved on a more global scale (all such imports auto-added or so), this problem is all over the place and it would be good if we could use this @link feature from the docs more reliably.
(just as some PR-unrelated side note)
There was a problem hiding this comment.
Yup, have done some research on this but haven't quite solved it yet. We need to somehow link via something like {@link module#referencedType } but I haven't figured out specifically how to implement yet.
ref issue: #3560
VerkleTree:
moves state
VerkleTree.createto 'constructors.ts'renames it to
createVerkleTree