Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trie static constructors doc updates #3622

Merged
merged 7 commits into from
Aug 29, 2024

Conversation

scorbajio
Copy link
Contributor

@scorbajio scorbajio commented Aug 29, 2024

This change update the trie package README to use the updated standalone functions instead of old static constructors that were refactored in #3515.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (4470cc3) to head (18e47e2).
Report is 25 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4470cc3) and HEAD (18e47e2). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (4470cc3) HEAD (18e47e2)
block 1 0
tx 1 0
wallet 1 0
Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block ?
client 0.00% <ø> (ø)
tx ?
wallet ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@scorbajio scorbajio merged commit 24b0dc2 into master Aug 29, 2024
39 of 40 checks passed
@scorbajio scorbajio deleted the trie-static-constructors-doc-updates branch August 29, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants