Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: rename verkleCrypto to verkle in common customCrypto #3797

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

gabrocheleau
Copy link
Contributor

This PR resolves #3795 by renaming verkleCrypto to verkle in common

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 75.84%. Comparing base (564020a) to head (6b3f0c3).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 73.74% <ø> (ø)
blockchain 83.25% <ø> (ø)
client 74.00% <ø> (ø)
common 89.89% <ø> (ø)
devp2p 71.95% <ø> (ø)
evm 64.93% <60.00%> (-0.01%) ⬇️
genesis 100.00% <ø> (ø)
mpt 52.34% <ø> (+0.25%) ⬆️
rlp 95.11% <ø> (ø)
statemanager 68.84% <66.66%> (+0.03%) ⬆️
tx 76.52% <ø> (ø)
util 72.73% <ø> (ø)
vm 57.30% <0.00%> (-0.05%) ⬇️
wallet 79.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77
holgerd77 previously approved these changes Nov 14, 2024
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@holgerd77
Copy link
Member

Ah, examples failing

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 94d72e5 into master Nov 15, 2024
40 of 41 checks passed
@holgerd77 holgerd77 deleted the common/rename-verkle-crypto branch November 15, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename verkleCrypto to verkle
2 participants