Skip to content
Back to pull request #817

refactor events to improve parameter order and indexing (#787) #2433

Sign in to view logs

refactor events to improve parameter order and indexing (#787)

refactor events to improve parameter order and indexing (#787) #2433

Triggered via pull request December 17, 2024 08:19
@doerflidoerfli
synchronize #817
feature/events-refactoring
Status Success
Total duration 6m 25s
Artifacts 2

build.yml

on: pull_request
Build and test (Hardhat)
2m 14s
Build and test (Hardhat)
Build contracts (Foundry - default profile with optimizer)
1m 16s
Build contracts (Foundry - default profile with optimizer)
Run tests (Foundry)
5m 42s
Run tests (Foundry)
Execute test deployment on local chain
1m 48s
Execute test deployment on local chain
Publish npm package to npmjs
23s
Publish npm package to npmjs
Fit to window
Zoom out
Zoom in

Annotations

15 warnings
Build contracts (Foundry - default profile with optimizer)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Build and test (Hardhat)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Build and test (Hardhat): contracts/accounting/AccountingService.sol#L10
imported name Fee is not used
Build and test (Hardhat): contracts/accounting/AccountingServiceManager.sol#L13
Explicitly mark visibility in function (Set ignoreConstructors to true if using solidity >=0.7.0)
Build and test (Hardhat): contracts/authorization/AccessAdmin.sol#L18
imported name ObjectType is not used
Build and test (Hardhat): contracts/authorization/AccessAdmin.sol#L107
Function name must be in mixedCase
Build and test (Hardhat): contracts/authorization/AccessAdminLib.sol#L46
Function name must be in mixedCase
Build and test (Hardhat): contracts/authorization/AccessAdminLib.sol#L56
Function name must be in mixedCase
Build and test (Hardhat): contracts/authorization/Authorization.sol#L30
Explicitly mark visibility in function (Set ignoreConstructors to true if using solidity >=0.7.0)
Build and test (Hardhat): contracts/authorization/ServiceAuthorization.sol#L33
Immutable variables name are set to be in capitalized SNAKE_CASE
Build and test (Hardhat): contracts/authorization/ServiceAuthorization.sol#L55
Explicitly mark visibility in function (Set ignoreConstructors to true if using solidity >=0.7.0)
Build and test (Hardhat): contracts/distribution/BasicDistributionAuthorization.sol#L19
Explicitly mark visibility in function (Set ignoreConstructors to true if using solidity >=0.7.0)
Execute test deployment on local chain
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Run tests (Foundry)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Publish npm package to npmjs
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Artifacts

Produced during runtime
Name Size
artifacts
14.6 MB
contract_sizes
3.89 KB