Skip to content
Build, test and publish

refactor RiskId (#824) #2455

Sign in to view logs

refactor RiskId (#824)

refactor RiskId (#824) #2455

Triggered via pull request December 23, 2024 12:10
@doerflidoerfli
opened #833
feature/risk-id-refactoring
Status Failure
Total duration 4m 8s
Artifacts 2

build.yml

on: pull_request
Build and test (Hardhat)
1m 48s
Build and test (Hardhat)
Build contracts (Foundry - default profile with optimizer)
1m 9s
Build contracts (Foundry - default profile with optimizer)
Run tests (Foundry)
26s
Run tests (Foundry)
Execute test deployment on local chain
2m 0s
Execute test deployment on local chain
Publish npm package to npmjs
0s
Publish npm package to npmjs
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 14 warnings
Run tests (Foundry)
Process completed with exit code 1.
Execute test deployment on local chain
Process completed with exit code 1.
Run tests (Foundry)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Build contracts (Foundry - default profile with optimizer)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Build and test (Hardhat)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Build and test (Hardhat): contracts/accounting/AccountingService.sol#L10
imported name Fee is not used
Build and test (Hardhat): contracts/accounting/AccountingServiceManager.sol#L13
Explicitly mark visibility in function (Set ignoreConstructors to true if using solidity >=0.7.0)
Build and test (Hardhat): contracts/authorization/AccessAdmin.sol#L18
imported name ObjectType is not used
Build and test (Hardhat): contracts/authorization/AccessAdmin.sol#L107
Function name must be in mixedCase
Build and test (Hardhat): contracts/authorization/AccessAdminLib.sol#L46
Function name must be in mixedCase
Build and test (Hardhat): contracts/authorization/AccessAdminLib.sol#L56
Function name must be in mixedCase
Build and test (Hardhat): contracts/authorization/Authorization.sol#L30
Explicitly mark visibility in function (Set ignoreConstructors to true if using solidity >=0.7.0)
Build and test (Hardhat): contracts/authorization/ServiceAuthorization.sol#L33
Immutable variables name are set to be in capitalized SNAKE_CASE
Build and test (Hardhat): contracts/authorization/ServiceAuthorization.sol#L55
Explicitly mark visibility in function (Set ignoreConstructors to true if using solidity >=0.7.0)
Build and test (Hardhat): contracts/distribution/BasicDistributionAuthorization.sol#L19
Explicitly mark visibility in function (Set ignoreConstructors to true if using solidity >=0.7.0)
Execute test deployment on local chain
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Artifacts

Produced during runtime
Name Size
artifacts
15.3 MB
contract_sizes
4 KB