contract types, refactor, add errors & events

etherisc · Nov 17, 2023 · cd98e97 · cd98e97
1 parent f14e6a9
commit cd98e97
Show file tree

Hide file tree

Showing 4 changed files with 268 additions and 143 deletions.
diff --git a/contracts/registry/IRegistry.sol b/contracts/registry/IRegistry.sol
@@ -10,9 +10,11 @@ import {IChainNft} from "./IChainNft.sol";
 
 interface IRegistry is IERC165 {
 
-    event Approval(NftId indexed nftId, ObjectType objectType);
+    event LogObjectRegistered(NftId nftId, NftId parentNftId, ObjectType objectType, address objectAddress, address initialOwner);
 
-    //TODO add more events
+    event LogServiceRegistered(address service, string serviceName, VersionPart majorVersion); 
+
+    event LogApproval(NftId nftId, ObjectType objectType);
 
     struct ObjectInfo {
         NftId nftId;
@@ -38,8 +40,7 @@ interface IRegistry is IERC165 {
 
     function allowance(
         NftId registrar,
-        ObjectType object,
-        ObjectType parent
+        ObjectType object
     ) external view returns (bool);
 
     function getObjectCount() external view returns (uint256);