partially implenent unstake (#418)

etherisc · Jul 2, 2024 · e664e06 · e664e06
1 parent 4023c64
commit e664e06
Show file tree

Hide file tree

Showing 3 changed files with 66 additions and 4 deletions.
diff --git a/contracts/pool/BundleService.sol b/contracts/pool/BundleService.sol
@@ -264,8 +264,26 @@ contract BundleService is
         virtual
         restricted()
     {
-        // TODO: implement
-        revert();
+        InstanceStore instanceStore = instance.getInstanceStore();
+        (
+            Amount balanceAmount,
+            Amount lockedAmount,
+            Amount feeAmount
+        ) = instanceStore.getAmounts(bundleNftId);
+
+        // TODO: should the available amount include the fees or not? 
+        Amount availableAmount = balanceAmount - (lockedAmount + feeAmount);
+
+        if (availableAmount < amount) {
+            revert ErrorBundleServiceStakeAmountExceedsLimit(amount, availableAmount);
+        }
+
+        _componentService.decreaseBundleBalance(
+            instanceStore, 
+            bundleNftId, 
+            amount, 
+            // TODO: if above includes fees, how to split this? 
+            AmountLib.zero());
     }
 
 

diff --git a/contracts/pool/IBundleService.sol b/contracts/pool/IBundleService.sol
@@ -31,6 +31,8 @@ interface IBundleService is IService {
     error ErrorBundleServiceFeesWithdrawAmountIsZero();
     error ErrorBundleServiceWalletAllowanceTooSmall(address wallet, address tokenHandler, uint256 allowance, uint256 amount);
 
+    error ErrorBundleServiceStakeAmountExceedsLimit(Amount amount, Amount limit);
+
     event LogBundleServiceFeesWithdrawn(NftId bundleNftId, address recipient, address tokenAddress, Amount amount);
 
     /// @dev create a new bundle for the specified attributes

diff --git a/contracts/pool/PoolService.sol b/contracts/pool/PoolService.sol
@@ -251,8 +251,50 @@ contract PoolService is
         restricted()
         returns(Amount netAmount) 
     {
-        // TODO: implement
-        revert();
+        (NftId poolNftId,, IInstance instance) = _getAndVerifyActiveComponent(POOL());
+        InstanceReader instanceReader = instance.getInstanceReader();
+        IBundle.BundleInfo memory bundleInfo = instanceReader.getBundleInfo(bundleNftId);
+
+        if (bundleInfo.poolNftId != poolNftId) {
+            revert ErrorPoolServiceBundlePoolMismatch(bundleNftId, poolNftId);
+        }
+
+        // call bundle service for bookkeeping and additional checks
+        _bundleService.unstake(instance, bundleNftId, amount);
+
+        (
+            Amount performanceFeeAmount,
+            Amount netAmount
+        ) = FeeLib.calculateFee(
+            _getPerformanceFee(instanceReader, poolNftId), 
+            amount);
+
+        // update pool bookkeeping - performance fees stay in the pool, but as fees 
+        _componentService.decreasePoolBalance(
+            instanceStore, 
+            poolNftId, 
+            amount, 
+            Amount.zero());
+
+        _componentService.increasePoolBalance(
+            instanceStore, 
+            poolNftId, 
+            Amount.zero(), 
+            performanceFeeAmount);
+
+        // TODO: transfer net amount to bundle owner (allowance)
+
+        // TODO: log event
+    }
+
+    function _getPerformanceFee(InstanceReader instanceReader, NftId poolNftId)
+        internal
+        virtual
+        view
+        returns (Fee memory performanceFee)
+    {
+        NftId productNftId = instanceReader.getPoolInfo(poolNftId).productNftId;
+        return instanceReader.getPoolInfo(productNftId).performanceFee;
     }
 
     function processSale(