Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/refactor base component #223

Merged
merged 4 commits into from
Feb 25, 2024
Merged

Feature/refactor base component #223

merged 4 commits into from
Feb 25, 2024

Conversation

matthiaszimmermann
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Todo Commenter

contracts/instance/service/BundleService.sol
TODO:
contracts/instance/service/PolicyService.sol
TODO:
  • no access restrictions Line: 84
  • add validations (see create bundle in pool service) Line: 182
  • add logging Line: 227
  • track policy associated to bundle in bundlemanager (tbd) and how much is locked for it Line: 268
  • add logging Line: 387
  • add logging Line: 423
  • add logging Line: 442
  • add logging Line: 536

@matthiaszimmermann Please take a look 👀

@matthiaszimmermann matthiaszimmermann merged commit 9dd1984 into develop Feb 25, 2024
9 checks passed
@matthiaszimmermann matthiaszimmermann deleted the feature/refactor-base-component branch February 25, 2024 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthiaszimmermann