Rename maxCapitalAmount to maxBalanceAmount in pool contracts (#476) #487

doerfli · 2024-07-09T07:12:00Z

github-actions · 2024-07-09T08:08:10Z

Todo Commenter

contracts/pool/PoolService.sol

restricted() (once Authz: Authorize component service call #462 is done) Line: 194
restricted() (once Authz: Authorize component service call #462 is done) Line: 246
handle performance fees (issue Implement performance fees #477) Line: 268
centralize token handling (issue Centralize token transfer code #471) Line: 291
centralize token handling (issue Centralize token transfer code #471) Line: 523

@doerfli Please take a look 👀

Rename maxCapitalAmount to maxBalanceAmount in pool contracts (#476)

5b7ceac

doerfli force-pushed the feature/maxcapitalamount branch from acef597 to 5b7ceac Compare July 9, 2024 07:14

doerfli added 2 commits July 9, 2024 07:15

update ide settings

ef44499

add unit tests (#476)

fa320a8

add unit test (#476)

ef8ce59

doerfli force-pushed the feature/maxcapitalamount branch from a9f21b8 to ef8ce59 Compare July 9, 2024 08:11

doerfli requested a review from matthiaszimmermann July 9, 2024 08:20

doerfli linked an issue Jul 9, 2024 that may be closed by this pull request

Implement PoolService.setMaxCapitalAmount #476

Closed

matthiaszimmermann approved these changes Jul 9, 2024

View reviewed changes

matthiaszimmermann merged commit 066cacc into develop Jul 9, 2024
12 checks passed

matthiaszimmermann deleted the feature/maxcapitalamount branch July 9, 2024 15:17

github-actions bot locked and limited conversation to collaborators Jul 9, 2024