Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #542 #543

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix #542 #543

merged 1 commit into from
Jul 19, 2024

Conversation

matthiaszimmermann
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Todo Commenter

contracts/distribution/DistributionService.sol
TODO:
contracts/pool/BundleService.sol
TODO:
contracts/pool/PoolService.sol
TODO:
contracts/product/ApplicationService.sol
TODO:
  • add logging Line: 170
contracts/product/PolicyService.sol
TODO:
  • add logging Line: 185
  • add callback IPolicyHolder.policyActivated() if applicable Line: 187
  • add logging Line: 231
  • add callback IPolicyHolder.policyActivated() if applicable Line: 235
  • add logging Line: 249
  • add callback IPolicyHolder.policyActivated() if applicable Line: 251
  • add callback IPolicyHolder.policyExpired() if applicable Line: 305

@matthiaszimmermann Please take a look 👀

@matthiaszimmermann
Copy link
Contributor Author

also simplifies (I)PolicyHolder

@matthiaszimmermann matthiaszimmermann merged commit b7eedf9 into develop Jul 19, 2024
12 checks passed
@matthiaszimmermann matthiaszimmermann deleted the feature/switch-visibilit-only-initializing-542 branch July 19, 2024 16:17
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthiaszimmermann