Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component lock (#590) #597

Merged
merged 9 commits into from
Aug 15, 2024
Merged

component lock (#590) #597

merged 9 commits into from
Aug 15, 2024

Conversation

doerfli
Copy link
Contributor

@doerfli doerfli commented Aug 14, 2024

No description provided.

@doerfli doerfli force-pushed the feature/component-lock branch from 9cde70f to 2a9fc40 Compare August 15, 2024 11:16
@doerfli doerfli force-pushed the feature/component-lock branch from cda82c1 to 8e9617f Compare August 15, 2024 13:57
Copy link
Contributor

Todo Commenter

contracts/distribution/DistributionService.sol
TODO:
contracts/examples/fire/FirePoolAuthorization.sol
TODO:
  • FirePool.createBundle must require a custom role (e.g. INVESTOR) instead of PUBLIC_ROLE Line: 29
contracts/examples/fire/FireProductAuthorization.sol
TODO:
  • add custom role for fire reporter Line: 40
contracts/instance/InstanceAdmin.sol
FIXME:
  • make this a bit nicer and work with IAuthorization. Use a specific role, not public - access to TokenHandler must be restricted Line: 130
contracts/pool/PoolService.sol
TODO:

@doerfli Please take a look 👀

@doerfli doerfli merged commit 47ee0bd into develop Aug 15, 2024
12 checks passed
@doerfli doerfli deleted the feature/component-lock branch August 15, 2024 14:01
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ComponentService.lock and ComponentService.unlock Implement InstanceService.setComponentLocked
3 participants