Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/accounting service #600

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Feature/accounting service #600

merged 5 commits into from
Aug 15, 2024

Conversation

doerfli
Copy link
Contributor

@doerfli doerfli commented Aug 15, 2024

No description provided.

@doerfli doerfli changed the base branch from develop to feature/component-lock August 15, 2024 11:25
@doerfli doerfli force-pushed the feature/accounting-service branch from e142d67 to be9b8d2 Compare August 15, 2024 13:45
@github-actions GitHub Actions
Copy link
Contributor

Todo Commenter

contracts/distribution/DistributionService.sol
TODO:
contracts/examples/fire/FirePoolAuthorization.sol
TODO:
  • FirePool.createBundle must require a custom role (e.g. INVESTOR) instead of PUBLIC_ROLE Line: 29
contracts/examples/fire/FireProductAuthorization.sol
TODO:
  • add custom role for fire reporter Line: 40
contracts/pool/PoolService.sol
TODO:

@doerfli Please take a look 👀

@doerfli doerfli merged commit cda82c1 into feature/component-lock Aug 15, 2024
11 checks passed
@doerfli doerfli deleted the feature/accounting-service branch August 15, 2024 13:52
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthiaszimmermann matthiaszimmermann Awaiting requested review from matthiaszimmermann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doerfli @matthiaszimmermann