Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend TokenHandler Authz #612

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Conversation

matthiaszimmermann
Copy link
Contributor

No description provided.

Copy link
Contributor

Todo Commenter

contracts/distribution/DistributionService.sol
TODO:
contracts/examples/fire/FirePoolAuthorization.sol
TODO:
  • FirePool.createBundle must require a custom role (e.g. INVESTOR) instead of PUBLIC_ROLE Line: 29
contracts/examples/fire/FireProductAuthorization.sol
TODO:
  • add custom role for fire reporter Line: 40
contracts/instance/InstanceAdmin.sol
FIXME:
  • make this a bit nicer and work with IAuthorization. Use a specific role, not public - access to TokenHandler must be restricted Line: 147
contracts/pool/PoolService.sol
TODO:
contracts/product/ClaimService.sol
TODO:
  • move to policy helper lib or something Line: 614

@matthiaszimmermann Please take a look 👀

@matthiaszimmermann matthiaszimmermann merged commit b214449 into develop Aug 21, 2024
12 checks passed
@matthiaszimmermann matthiaszimmermann deleted the feature/token-handler-authz branch August 21, 2024 18:51
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant