validate distributor type/referral belong to calling distribution component (#623) #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
doerfli
commented
Aug 26, 2024
•
doerfli
commented
- check distribution when creating distributor type
- add test
- check distribution when changing distributor type
- add test
- check distributor type and distribution when creating referral
- add test
- check referral belongs to same product when calculating price
- add test
- check referral belongs to same product when creating application
- add test
doerfli
changed the title
doerfli
force-pushed
the
bugfix/referral-same-product-check
branch
from
ea356c0 to
ba7ea4e
Compare
doerfli
requested review from
matthiaszimmermann
and removed request for
matthiaszimmermann
Todo Commentercontracts/distribution/DistributionService.solTODO:
contracts/product/ApplicationService.solTODO:
@doerfli Please take a look 👀 |
matthiaszimmermann
approved these changes
Aug 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.