Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/check-riskid-reference #640

Merged
merged 8 commits into from
Aug 27, 2024
Merged

Bugfix/check-riskid-reference #640

merged 8 commits into from
Aug 27, 2024

Conversation

doerfli
Copy link
Contributor

@doerfli doerfli commented Aug 27, 2024 •
edited
Loading

  • check product reference during risk update
  • add test
  • check product reference during risk state update
  • add test
  • check product reference during price calculation
  • add test
  • check product reference during application
  • add test

@github-actions GitHub Actions
Copy link
Contributor

Todo Commenter

contracts/product/ApplicationService.sol
TODO:
  • add logging Line: 187

@doerfli Please take a look 👀

Base automatically changed from bugfix/referral-same-product-check to develop August 27, 2024 12:22
@doerfli doerfli merged commit 754ba48 into develop Aug 27, 2024
11 checks passed
@doerfli doerfli deleted the bugfix/check-riskid-reference branch August 27, 2024 12:29
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthiaszimmermann matthiaszimmermann matthiaszimmermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doerfli @matthiaszimmermann