Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add missing instance functions #585 #645

Merged

Conversation

matthiaszimmermann
Copy link
Contributor

No description provided.

@doerfli doerfli changed the title Feature/add missing instance functions 585 Feature/add missing instance functions #585 Aug 27, 2024
Copy link

gitguardian bot commented Aug 30, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11712615 Triggered Generic High Entropy Secret 440c9e5 test/base/GifDeployer.t.sol View secret
11712616 Triggered Generic High Entropy Secret 440c9e5 test/mock/ServiceAuthorizationMock.sol View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Todo Commenter

contracts/product/ClaimService.sol
TODO:
  • move to policy helper lib or something Line: 613

@matthiaszimmermann Please take a look 👀

@matthiaszimmermann matthiaszimmermann merged commit 5b936e6 into develop Sep 3, 2024
12 checks passed
@matthiaszimmermann matthiaszimmermann deleted the feature/add-missing-instance-functions-585 branch September 3, 2024 18:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant