fix: review comments

ethersphere · Nov 29, 2023 · 125d444 · 125d444
1 parent de97ab0
commit 125d444
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 14 deletions.
diff --git a/cmd/bee/cmd/split.go b/cmd/bee/cmd/split.go
@@ -14,7 +14,6 @@ import (
 	"github.com/ethersphere/bee/pkg/file/splitter"
 	"github.com/ethersphere/bee/pkg/storage"
 	"github.com/ethersphere/bee/pkg/swarm"
-
 	"github.com/spf13/cobra"
 )
 

diff --git a/cmd/bee/cmd/split_test.go b/cmd/bee/cmd/split_test.go
@@ -7,10 +7,9 @@ package cmd_test
 import (
 	"bufio"
 	crand "crypto/rand"
-	"errors"
-	"io"
 	"math/rand"
 	"os"
+	"path"
 	"testing"
 
 	"github.com/ethersphere/bee/cmd/bee/cmd"
@@ -27,13 +26,13 @@ func TestDBSplit(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	inputFileName := t.TempDir() + "/input"
+	inputFileName := path.Join(t.TempDir(), "input")
 	err = os.WriteFile(inputFileName, buf, 0644)
 	if err != nil {
 		t.Fatal(err)
 	}
 
-	outputFileName := t.TempDir() + "/output"
+	outputFileName := path.Join(t.TempDir(), "output")
 
 	err = newCommand(t, cmd.WithArgs("split", "--input-file", inputFileName, "--output-file", outputFileName)).Execute()
 	if err != nil {
@@ -52,15 +51,8 @@ func TestDBSplit(t *testing.T) {
 		t.Fatal(err)
 	}
 	defer f.Close()
-	reader := bufio.NewReader(f)
-	for {
-		_, err = reader.ReadString('\n')
-		if err != nil {
-			if errors.Is(err, io.EOF) {
-				break
-			}
-			t.Fatal(err)
-		}
+	scanner := bufio.NewScanner(f)
+	for scanner.Scan() {
 		gotHashes++
 	}