chore(pusher): logging address of shallow receipt (#4393)

ethersphere · Oct 11, 2023 · 8b150cf · 8b150cf
1 parent 5d00652
commit 8b150cf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/pkg/pusher/pusher.go b/pkg/pusher/pusher.go
@@ -381,7 +381,7 @@ func (s *Service) checkReceipt(receipt *pushsync.Receipt, loggerV1 log.Logger) e
 	if po < d && s.attempts.try(addr) {
 		s.metrics.ShallowReceiptDepth.WithLabelValues(strconv.Itoa(int(po))).Inc()
 		s.metrics.ShallowReceipt.Inc()
-		return fmt.Errorf("pusher: shallow receipt depth %d, want at least %d: %w", po, d, ErrShallowReceipt)
+		return fmt.Errorf("pusher: shallow receipt depth %d, want at least %d, chunk_address %s: %w", po, d, addr, ErrShallowReceipt)
 	}
 	loggerV1.Debug("chunk pushed", "chunk_address", addr, "peer_address", peer, "proximity_order", po)
 	s.metrics.ReceiptDepth.WithLabelValues(strconv.Itoa(int(po))).Inc()

diff --git a/pkg/sharky/shard.go b/pkg/sharky/shard.go
@@ -172,8 +172,11 @@ func (sh *shard) offset(slot uint32) int64 {
 
 // read reads loc.Length bytes to the buffer from the blob slot loc.Slot
 func (sh *shard) read(r read) error {
-	_, err := sh.file.ReadAt(r.buf, sh.offset(r.slot))
-	return err
+	n, err := sh.file.ReadAt(r.buf, sh.offset(r.slot))
+	if err != nil {
+		return fmt.Errorf("read %d: %w", n, err)
+	}
+	return nil
 }
 
 // write writes loc.Length bytes to the buffer from the blob slot loc.Slot