fix: tracing for pushsync and retrieval #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acha-bill
force-pushed
the
fix-tracing
branch
from
a39273f to
61717bf
Compare
|
@acha-bill please, have a followup regarding this please to see where we are |
notanatol
force-pushed
the
fix-tracing
branch
from
2c4c55d to
1fd4ff5
Compare
notanatol
changed the title
notanatol
force-pushed
the
fix-tracing
branch
2 times, most recently
from
3424427 to
18018d5
Compare
notanatol
changed the title
notanatol
added
ready for review
notanatol
force-pushed
the
fix-tracing
branch
from
6149eb4 to
9c9b5e2
Compare
mrekucci
reviewed
Nov 7, 2023
pkg/api/bytes.go
Outdated
| @@ -26,7 +29,8 @@ type bytesPostResponse struct { | |||
|
|
|||
| // bytesUploadHandler handles upload of raw binary data of arbitrary length. | |||
| func (s *Service) bytesUploadHandler(w http.ResponseWriter, r *http.Request) { | |||
| logger := tracing.NewLoggerWithTraceID(r.Context(), s.logger.WithName("post_bytes").Build()) | |||
| span, logger, ctx := s.tracer.StartSpanFromContext(r.Context(), "post-bytes", s.logger.WithName("post-bytes").Build()) | |||
There was a problem hiding this comment.
The convention we use is an underscore for the logger names, the same is below.
istae
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Closes: #3795