Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save stamps for all upload types regardless of any errors #4327

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

istae
Copy link
Member

@istae istae commented Sep 20, 2023

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

The stamp indexes are saved to disk after every upload session regardless of upload result.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

@ethersphere ethersphere deleted a comment from istae Sep 20, 2023
@istae istae merged commit 038dbfb into master Sep 20, 2023
13 checks passed
@istae istae deleted the immutable-old-index branch September 20, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

immutable batches upload overwrite index issue when node is restarted
3 participants