Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump storage-incentives abi to v0.6.0-rc3 #4348

Merged
merged 14 commits into from
Sep 27, 2023
Merged

Conversation

nugaon
Copy link
Member

@nugaon nugaon commented Sep 26, 2023

bump go-storage-incentives-abi dependency for redistribution contract testnet deployment and reactive redistribution contract related tests

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

@nugaon nugaon changed the title fix(storageincentives): testnet preparation fix(ph4): testnet preparation Sep 26, 2023
@istae istae requested a review from mrekucci September 27, 2023 14:30
@istae istae marked this pull request as ready for review September 27, 2023 14:35
@@ -28,33 +29,35 @@ import (
var redistributionContractABI = abiutil.MustParseABI(chaincfg.Testnet.RedistributionABI)

// TODO uncomment when ABI is updated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ABI was updated, shouldn't this be uncommented?

@mrekucci mrekucci changed the title fix(ph4): testnet preparation fix: bump storage-incentives abi to v0.6.0-rc3 Sep 27, 2023
@nugaon nugaon merged commit c53032d into feat/phase4 Sep 27, 2023
13 checks passed
@nugaon nugaon deleted the fix/ph4-testnet branch September 27, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants