feat: include abi custom error params in the returned error #4376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrekucci
force-pushed
the
unwrap-abi-error-params
branch
from
3a97911 to
46505a2
Compare
mrekucci
changed the title
mrekucci
force-pushed
the
unwrap-abi-error-params
branch
3 times, most recently
from
8211f1e to
88aaeba
Compare
istae
approved these changes
Oct 4, 2023
pkg/transaction/transaction.go
Outdated
| res, cErr := t.Call(ctx, req) | ||
| if cErr != nil { | ||
| _, cErr := t.Call(ctx, req) | ||
| var derr rpc.DataError |
janos
reviewed
Oct 4, 2023
mrekucci
force-pushed
the
unwrap-abi-error-params
branch
2 times, most recently
from
7569126 to
2acb164
Compare
mrekucci
force-pushed
the
unwrap-abi-error-params
branch
2 times, most recently
from
46e70fb to
f947335
Compare
mrekucci
force-pushed
the
unwrap-abi-error-params
branch
3 times, most recently
from
0c792db to
d434b9d
Compare
mrekucci
force-pushed
the
unwrap-abi-error-params
branch
from
d434b9d to
23bd367
Compare
mrekucci
pushed a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Includes abi error params in the returned error.
Example of the output error:
execution reverted: InsufficientBalance(available=0,required=111)for the following failed transaction: https://goerli.etherscan.io/tx/0x74a2577db1c325c41e38977aa1eb32ab03dfa17cc1fa0649e84f3d8c0f0882ee