Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache and stamper store #4433

Merged
merged 14 commits into from
Oct 31, 2023
Merged

fix: cache and stamper store #4433

merged 14 commits into from
Oct 31, 2023

Conversation

istae
Copy link
Member

@istae istae commented Oct 27, 2023

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Includes various improvements to how the cache works.
The storer now has a cache worker that keeps track of the cache size and evicts as necessary.
This means that other cache ops do not need to remove any items before inserting entries.

In the postage service, the set expire func now removes all expired stamp issuers and stamp data.

Added new metrics to cachestore.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

@istae istae requested review from acha-bill and mrekucci October 27, 2023 14:04
@istae istae self-assigned this Oct 27, 2023
@istae istae changed the title fix: cache store fix: cache and stamper store Oct 27, 2023
@istae istae marked this pull request as ready for review October 27, 2023 23:16
pkg/postage/service.go Show resolved Hide resolved
@istae istae merged commit f32ff23 into master Oct 31, 2023
13 checks passed
@istae istae deleted the fix-cachestore branch October 31, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants