Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postage_api): check if batch exists for stamp issuer #4440

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

istae
Copy link
Member

@istae istae commented Nov 2, 2023

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

For older stamps that have not been removed because postage resyncing has not taken place, the API must check the existence of the issuer as well as the batch.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

@istae istae requested review from acha-bill and notanatol November 2, 2023 12:43
@istae istae merged commit 9221ed0 into master Nov 2, 2023
13 checks passed
@istae istae deleted the fix-batch-exists branch November 2, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants