Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migration of batches #4483

Closed
wants to merge 1 commit into from
Closed

fix: migration of batches #4483

wants to merge 1 commit into from
+1 −1

Conversation

mrekucci
Copy link
Contributor

@mrekucci mrekucci commented Nov 29, 2023 •
edited
Loading

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.

@mrekucci mrekucci requested review from istae and acha-bill November 29, 2023 09:41
@istae
Copy link
Member

istae commented Nov 29, 2023

why is this change required?
these entries get removed as part of "postage", "batchstore", "addressbook_entry_"
afaik only "batchstore_" entries need to be removed

@mrekucci
Copy link
Contributor Author

why is this change required? these entries get removed as part of "postage", "batchstore", "addressbook_entry_" afaik only "batchstore_" entries need to be removed

They are not required, this PR was open just for testing purposes.

@mrekucci mrekucci closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notanatol notanatol notanatol approved these changes

@istae istae Awaiting requested review from istae istae is a code owner

@acha-bill acha-bill Awaiting requested review from acha-bill acha-bill is a code owner

Assignees
No one assigned
Labels
pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrekucci @istae @notanatol