Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to the sepolia testnet (#4465) #4500

Merged
merged 7 commits into from
Feb 2, 2024
Merged

Conversation

mrekucci
Copy link
Contributor

@mrekucci mrekucci commented Dec 11, 2023

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Switch from the Goerli testnet to the Sepolia testnet.

Closes #3949

@mrekucci mrekucci mentioned this pull request Dec 20, 2023
4 tasks
@acha-bill acha-bill marked this pull request as ready for review January 17, 2024 17:41
go.mod Outdated
github.com/ethersphere/go-storage-incentives-abi v0.6.0
github.com/ethersphere/go-sw3-abi v0.4.0
github.com/ethersphere/go-price-oracle-abi v0.2.0
github.com/ethersphere/go-storage-incentives-abi v0.6.1-rc3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we are using an -rc tag, is this safe to be merged to master and released?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RC is because the actual release is still on goerli as when you built nodes so far you used it and If sepolia was in release then you would have problem. If we are ready I can add it to official release also and different TAG can be used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to merge this to master then we probably shouldn't be using RCs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notanatol
Copy link
Contributor

lgtm but there's a lot of mentions of 'goerli' in various places, maybe this is a good place to update them.

Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @notanatol about the goerli mentions in the codebase. And it is better to keep the practice not to merge to master rc versions, even if it is for the testnet only.

@0xCardinalError
Copy link

lgtm but there's a lot of mentions of 'goerli' in various places, maybe this is a good place to update them.

please someone do that for Bee node.
in storage incentives repo I removed all goerli mentions

@acha-bill acha-bill merged commit 4532f79 into master Feb 2, 2024
12 checks passed
@acha-bill acha-bill deleted the sepolia-migration branch February 2, 2024 12:54
istae added a commit that referenced this pull request Feb 6, 2024
istae added a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to Sepolia or buy gETH for testing purposes
7 participants