-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch to the sepolia testnet (#4465) #4500
Conversation
1da142e
to
f382908
Compare
f0bb0d0
to
c5e502c
Compare
go.mod
Outdated
github.com/ethersphere/go-storage-incentives-abi v0.6.0 | ||
github.com/ethersphere/go-sw3-abi v0.4.0 | ||
github.com/ethersphere/go-price-oracle-abi v0.2.0 | ||
github.com/ethersphere/go-storage-incentives-abi v0.6.1-rc3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we are using an -rc tag, is this safe to be merged to master and released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RC is because the actual release is still on goerli as when you built nodes so far you used it and If sepolia was in release then you would have problem. If we are ready I can add it to official release also and different TAG can be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to merge this to master then we probably shouldn't be using RCs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a problem, here is non-RC release
https://github.com/ethersphere/go-storage-incentives-abi/tree/v0.6.2
lgtm but there's a lot of mentions of 'goerli' in various places, maybe this is a good place to update them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @notanatol about the goerli mentions in the codebase. And it is better to keep the practice not to merge to master rc versions, even if it is for the testnet only.
please someone do that for Bee node. |
Checklist
Description
Switch from the Goerli testnet to the Sepolia testnet.
Closes #3949