feat: redundancy retrieve api #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zelig
force-pushed
the
feat/redundancy-api-tests
branch
from
ccb89ca to
aefd316
Compare
nugaon
reviewed
Jan 15, 2024
Comment on lines
+108
to
+110
| if levels == 1 { | ||
| forget = 2 | ||
| } |
There was a problem hiding this comment.
I don't understand this part. why is it 2?
Comment on lines
+113
to
+115
| for j := 2; j < levels; j++ { | ||
| gap *= shardCnt | ||
| } |
There was a problem hiding this comment.
at line 209 you define only {1, 2, 3} for levels, so this basically takes into action for 3 only. I also do not really understand why it is necessary.
|
|
||
| // GetLevelFromContext is a helper function to extract the redundancy level from the context | ||
| func GetLevelFromContext(ctx context.Context) Level { | ||
| rlevel := PARANOID |
There was a problem hiding this comment.
this only regards to the dispersed replica lookup, maybe its documentation could be amended.
pkg/util/ioutil/pseudorand/reader.go
Outdated
| // New creates a new pseudorandom reader seeded with the given seed. | ||
| func NewReader(seed []byte, l int) *Reader { | ||
| r := &Reader{len: l} | ||
| _ = copy(r.buf[8:], seed) |
There was a problem hiding this comment.
why is the first 8 byte left out?
pkg/util/ioutil/pseudorand/reader.go
Outdated
| } | ||
| bufSegments := bufSize / 32 | ||
| start := r.cur / bufSegments | ||
| rem := (r.cur % bufSize) / 32 |
There was a problem hiding this comment.
first it is devided by 32 then you multiply it by that. it is not necessary
Co-authored-by: nugaon <[email protected]>
Co-authored-by: Gyorgy Barabas <[email protected]>
zelig
force-pushed
the
feat/redundancy-api-tests
branch
from
1e0b0e9 to
218fe7e
Compare
|
Overall, I think we should keep some pre-fetching mechanism for case when the data is not erasure coded. Without that, data retrieval may be really slow. |
…kahead via header
zelig
force-pushed
the
feat/redundancy-api-tests
branch
from
3660deb to
3a47dc6
Compare
zelig
force-pushed
the
feat/redundancy-api-tests
branch
3 times, most recently
from
dcb5ae6 to
56754cb
Compare
zelig
force-pushed
the
feat/redundancy-api-tests
branch
from
56754cb to
969a134
Compare
notanatol
approved these changes
Feb 4, 2024
acha-bill
approved these changes
Feb 6, 2024
istae
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the final push of non-local redundancy.
contains extensive joiner and bzz api tests to demonstrate the correctness of the various decoder prefetching strategies and to test header-based setting of paramater values.
The PR also contains many fixes:
remove langos and not use prebuffering on endointsUPDATE: the final push contains the following improvements: