Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stamper fixes #4556

Merged
merged 2 commits into from
Jan 31, 2024
Merged

feat: stamper fixes #4556

merged 2 commits into from
Jan 31, 2024

Conversation

acha-bill
Copy link
Contributor

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Stamp fixes
#4552

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

@acha-bill acha-bill changed the title feat: stamper index assignment rule update (#4552) feat: stamper fixes Jan 23, 2024
@istae istae marked this pull request as ready for review January 25, 2024 14:31
@istae istae requested review from istae and notanatol January 25, 2024 14:31
istae
istae requested changes Jan 25, 2024
View reviewed changes
pkg/postage/stamper.go Outdated Show resolved Hide resolved
@acha-bill acha-bill requested a review from istae January 31, 2024 00:26
istae
istae approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@istae istae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@acha-bill acha-bill merged commit bf3a755 into master Jan 31, 2024
12 checks passed
@acha-bill acha-bill deleted the feat/stamp-fixes branch January 31, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notanatol notanatol notanatol approved these changes

@istae istae istae approved these changes

Assignees
No one assigned
Labels
pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acha-bill @istae @notanatol