fix(localstore): leveldb-batch based transactions for both index and chunkstore for every localstore op #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istae
force-pushed
the
localstore-cleanup
branch
from
9424557 to
9cc6f52
Compare
istae
commented
Jan 30, 2024
pkg/node/node.go
Outdated
| @@ -184,8 +184,8 @@ const ( | |||
| minPaymentThreshold = 2 * refreshRate // minimal accepted payment threshold of full nodes | |||
| maxPaymentThreshold = 24 * refreshRate // maximal accepted payment threshold of full nodes | |||
| mainnetNetworkID = uint64(1) // | |||
| ReserveCapacity = 4_194_304 // 2^22 chunks | |||
| reserveWakeUpDuration = 30 * time.Minute // time to wait before waking up reserveWorker | |||
| ReserveCapacity = 16384 // 2^14 chunks | |||
There was a problem hiding this comment.
TODO: remove before merge to master
1 task
istae
force-pushed
the
localstore-cleanup
branch
5 times, most recently
from
7b034fe to
174c1aa
Compare
istae
force-pushed
the
localstore-cleanup
branch
from
65bb262 to
849c9b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
An extensive cleanup of the db transaction.
Every localstore write operation now utilizes a transaction. Calls to the chunkstore are also part of the transaction.
also tackled: evict just enough chunks of a batch to fall below the reserve capacity
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
closes #4341 #4538
Screenshots (if appropriate):