Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload store fixes #4562

Merged
merged 8 commits into from
Feb 5, 2024
Merged

fix: upload store fixes #4562

merged 8 commits into from
Feb 5, 2024

Conversation

acha-bill
Copy link
Contributor

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

  1. Remove stamp index check from uploadPutter.Put
  2. Delete all associated uploadItems after close

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Closes #4541

Screenshots (if appropriate):

@acha-bill acha-bill force-pushed the feat/upload-store-fixes branch from 5e16433 to 9c1a8d3 Compare January 31, 2024 15:40
@istae
Copy link
Member

istae commented Jan 31, 2024

we should also add a new migration step that removes all leftover items from previous sessions.
in the next release, we can add a line in the release notes that the new release will cleanup all upload items so that before deploying the new release, all uploads must first finish.

pkg/storer/migration/step_05.go Outdated Show resolved Hide resolved
@acha-bill acha-bill requested a review from istae February 5, 2024 09:50
@acha-bill acha-bill self-assigned this Feb 5, 2024
@acha-bill acha-bill merged commit 771a40b into master Feb 5, 2024
12 checks passed
@acha-bill acha-bill deleted the feat/upload-store-fixes branch February 5, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uploadstore fixes
3 participants