fix: remove epoch migration code #4563
Conversation
|
should remove these as well: |
notanatol
force-pushed
the
fix-epoch-cleanup
branch
from
f41ed05 to
86a1f93
Compare
pkg/statestore/test/store.go
Outdated
| @@ -225,5 +225,5 @@ func testStoreIterator(t *testing.T, store storage.StateStorer, prefix string, s | |||
| func testEmpty(t *testing.T, store storage.StateStorer) { | |||
| t.Helper() | |||
|
|
|||
| testStoreIterator(t, store, "", 1) // 1 because of the schema entry. | |||
| testStoreIterator(t, store, "", 0) // 1 because of the schema entry. | |||
There was a problem hiding this comment.
@istae is this comment still relevant?
do we still have 'schema entry' or was it part of the previous localstore?
There was a problem hiding this comment.
this schema entry probably has to do with the empty prefix and the way leveldb is implemented?
maybe @janos can help us here?
There was a problem hiding this comment.
which begs the question, how does changing it to 0 continue to work?
There was a problem hiding this comment.
looks like we used to manually insert a schema entry to keep a track of the migrations https://github.com/ethersphere/bee/blob/master/pkg/statestore/leveldb/leveldb.go#L176
but now that migrations are handled elsewhere, it is okay to remove that comment @notanatol
There was a problem hiding this comment.
Yes, that is correct, schema name was inserted under a specific key, but now since putSchemaName is not used, 0 is the correct value. Comment should be removed.
notanatol
force-pushed
the
fix-epoch-cleanup
branch
from
86a1f93 to
365361e
Compare
notanatol
changed the title
Checklist
Description
closes #4540