refactor(postage): enable parallel test #4656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinconic
reviewed
Jun 11, 2024
|
|
||
| // tests a valid stamp | ||
| t.Run("valid stamp", func(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| owner, signer := generateOwnerAndSigner(t) |
There was a problem hiding this comment.
Do we have to generate/get owner, signer every time for each test?
There was a problem hiding this comment.
If we generate/get owner, signer just once as we were doing before, then the test fails with the following error
ethersphere/bee/v2/pkg/postage
--- FAIL: TestStamperStamping (0.01s)
--- FAIL: TestStamperStamping/reuse_index_but_get_new_timestamp_for_mutable_or_immutable_batch (0.00s)
/Users/ersonpereira/Workspace/work/bee/pkg/postage/stamper_test.go:142: expected no error, got owner mismatch
--- FAIL: TestStamperStamping/valid_stamp (0.00s)
/Users/ersonpereira/Workspace/work/bee/pkg/postage/stamper_test.go:53: expected no error, got owner mismatch
FAIL
FAIL github.com/ethersphere/bee/v2/pkg/postage 0.513s
FAIL
So generating owner, signer for each test fixes this issue.
acha-bill
reviewed
Jun 12, 2024
|
we recently parallelized these tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Enable parallel testing in pkg/postage by adding
t.Parallel()to test functions, convert some code to helper functions to fix scope issues, uset.Cleanup()instead ofdeferin Parallel tests, and remove disable paralleltest onpkg/postagefrom.golangci.yml.Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
closes #3831
Screenshots (if appropriate):