Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes on the bee side to use the correct functions and send the correct function args for contracts #4718

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

martinconic
Copy link
Contributor

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

As part of Neighbourhood hopping (new staking - part 1 - SWIP-19)

@martinconic martinconic requested review from istae, janos and acha-bill July 5, 2024 11:41
Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are reflecting the changes in the contract, but maybe the beekeeper test should be updated as well as ci-stake is failing https://github.com/ethersphere/bee/actions/runs/9807662976/job/27081875692?pr=4718#step:19:27 with Error: running check ci-stake: check initial staked amount.

@martinconic martinconic force-pushed the feat/refactor-updated-contracts branch from 7f0b83d to 57e5caa Compare July 8, 2024 07:51
@martinconic martinconic force-pushed the feat/refactor-updated-contracts branch from 57e5caa to 9f4f52d Compare July 8, 2024 07:52
@martinconic martinconic requested a review from janos July 8, 2024 22:19
Copy link
Member

@istae istae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinconic
Copy link
Contributor Author

These changes are reflecting the changes in the contract, but maybe the beekeeper test should be updated as well as ci-stake is failing https://github.com/ethersphere/bee/actions/runs/9807662976/job/27081875692?pr=4718#step:19:27 with Error: running check ci-stake: check initial staked amount.

Issue solved by ethersphere/beekeeper#404

@martinconic martinconic merged commit 41030fc into master Jul 9, 2024
14 checks passed
@martinconic martinconic deleted the feat/refactor-updated-contracts branch July 9, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants