feat: swip 20 staking changes #4728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nugaon
suggested changes
Jul 19, 2024
Comment on lines
1023
to
1035
| transactionMock.WithWaitForReceiptFunc(func(ctx context.Context, txHash common.Hash) (receipt *types.Receipt, err error) { | ||
| if txHash == txHashApprove { | ||
| return &types.Receipt{ | ||
| Status: 1, | ||
| }, nil | ||
| } | ||
| if txHash == txHashWithdrawn { | ||
| return &types.Receipt{ | ||
| Status: 1, | ||
| }, nil | ||
| } | ||
| return nil, errors.New("unknown tx hash") | ||
| }), |
There was a problem hiding this comment.
it will not reach the receipt part
acha-bill
reviewed
Jul 19, 2024
martinconic
reviewed
Jul 23, 2024
| } | ||
|
|
||
| if len(prevStakedAmount.Bits()) == 0 { | ||
| if stakedAmount.Cmp(MinimumStakeAmount) == -1 { |
There was a problem hiding this comment.
why == -1 and not <= -1 ?
There was a problem hiding this comment.
-1 means that the staked amount is less than the minimum,
0 would mean equal
1 would mean staked amount is greater than the minimum
There was a problem hiding this comment.
the Cmp func strictly returns the values above
martinconic
approved these changes
Jul 23, 2024
acha-bill
approved these changes
Jul 24, 2024
acha-bill
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Changes on the bee side in correspondence to ethersphere/storage-incentives#264 and ethersphere/SWIPs#49
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):