Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various swip21 fixes #4874

Merged
merged 3 commits into from
Oct 23, 2024
Merged

fix: various swip21 fixes #4874

merged 3 commits into from
Oct 23, 2024

Conversation

istae
Copy link
Member

@istae istae commented Oct 22, 2024

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

reserve: trigger eviction in the worker if the size is above capacity
agent: check if the node is frozen starting with the next block

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

@istae istae changed the title fix(reserve): trigger eviction in the worker if the size is above cap… fix: various swip21 fixes Oct 23, 2024
@istae
Copy link
Member Author

istae commented Oct 23, 2024

it turns out that we check if a node is frozen by comparing the lastUpdatedBlockNumberOfAddress with the most recent block height here
which gets called by the agent here
as soon as the node start up, it updates the height in the staking contract which updates the lastUpdatedBlockNumberOfAddress with the current block, next this agent gets initialized, and since we are at the same block height, the IsOverlayFrozen check returns true bumping the block in this call by one should fix this issue

@istae istae merged commit 13fc473 into master Oct 23, 2024
14 checks passed
@istae istae deleted the trigger-eviction branch October 23, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants