Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typos in Addresses struct tags #407

Merged

Conversation

ferencsarai
Copy link
Member

No description provided.

@gacevicljubisa
Copy link
Contributor

gacevicljubisa commented Jul 17, 2024

this is beacuse not all changes were reflected after this ethersphere/bee#1613, and pss was made before #118
also, it seems that pssPublicKey was used here

err = nodeA.SendPSSMessage(ctx, addrB.Overlay, addrB.PSSPublicKey, testTopic, o.AddressPrefix, testData, batchID)

@istae can you double check that test is valid for this SendPSSMessage?

@istae
Copy link
Member

istae commented Jul 17, 2024

@gacevicljubisa this is the struct on the bee side

type addressesResponse struct {
	Overlay      *swarm.Address        `json:"overlay"`
	Underlay     []multiaddr.Multiaddr `json:"underlay"`
	Ethereum     common.Address        `json:"ethereum"`
	PublicKey    string                `json:"publicKey"`
	PSSPublicKey string                `json:"pssPublicKey"`
}

@istae istae merged commit b017aef into ethersphere:master Jul 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants